Angus Leeming <[EMAIL PROTECTED]> writes:

| > Let's see how it works in 1.2.0cvs first.
| 
| Fair point.
| 
| Here is the patch. Visible changes:
| * Adds a "Use Natbib" check button to the Document dialog (tab Extra).

I'd rather hide this from the user (and I really want to get rid of
the extra stuff).
 
| * When natbib is enabled, the Citation dialog has a choice for the \citeX 
| command.

Those commands should be renamed no "\citeX" anything should ever be
visible to the user.
 
| * I threw in the Browse Button in Print Dialog patch, because it's
|    small, has no issues associated and I couldn't be bothered
|    separating it out. 

Please bother.
 
| Issues:
| * Toggling the "Use Natbib" button does not update the Citation dialog. The 
| dialog must be closed/opened again (or the Restore button pressed if active).
| 
| * Toggling "Use Natbib" Off will not change the LaTeX output from \citet, 
| \citep etc to \cite. Ie, the output will be incorrect. You'll have to 
| open/close each Citation inset by hand.

So this should not be fixed in the inset, but discovered upon
writeout.
 
| * Cannot input comments before the citation when in natbib mode. The 
| InsetCommandParams::options field must be altered to take multiple options 
| before this can occur. Thoughts:
| 
|       make options a vector<string> and access is with 
|       void setOption(string, int = 0)
|       string getOption(int = 0)

hmm, why the int? use a map instead.
Look in Variables.C.

| ie, behaviour is identical for most insets, but those that want multiple 
| options can have 'em. No idea about how to output this to the LyX file. Any 
| ideas?
| 
| Finally:
| 
| I'm not at all sure that I've done the use_natbib stuff correctly. Basically, 
| I just copied use_amsmath. It all seems to work, but if someone in the know 
| would check this over, I'd be very grateful.

A branch to do this in would probably be nice.

        Lgb

Reply via email to