09/02/2014 15:30, Georg Baum:
You mean resetFontEdit() should return return true if isPassThru() returns
true? This would certainly make sense, but I am not sure if we should do it
now. My proposed patch is conservative in the sense that the behaviour is
not changed for any inset except the chunk inset.
OK, apply your path as it is now, it is the safest bet at this stage. I
have added your comment to the bug report for posterity's sake.
Just code comments: can resetFontEdit be rewritten as follows? It seems
clearer to me.
+bool Inset::resetFontEdit() const
+{
+ return getLayout().resetsFont() || !inheritFont();
+}
Also the comment over resetsFontEdit may need a clean up, e.g. the
following snippet:
For copy/paste the operations the language is never changed, since
Thanks for looking at this.
JMarc
