Am 16.01.2014 um 10:49 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>:
> 16/01/2014 07:32, Stephan Witt: >> Attached is a patch to work around a bug with crash on view close on Mac OSX. >> See also https://bugreports.qt-project.org/browse/QTBUG-25399 >> >> Is anyone able to verify or comment it? > > I am unfortunately no in a position to test it out. My only comment is that > the whole handling of dialogs that do not require a view is broken and should > be moved to GuiApplication. The code in GuiApplication should not be guarded > by #ifdef, you could just add a comment that this normally only trigger with > Mac OS. That's not true, IMHO. The dispatch and getstatus calls are made for application first and the for the view. The platform doesn't matter here. It's different for a Mac to have a menu bar without any view. But you're right if you meant to say it works on any platform. > This way the code is always compiled in. > > In a precedent version of the patch, you created a dummy view to do the > dispatch. How come it is not necessary anymore? How is the dispatch done? Yes, you're right. This is not handled intentionally. This and the #ifdefs was made to reduce the size of the impact of the patch. I'll attach another patch * without #ifdef * with dummy view to do the dispatch This works better, but affects the code more. Stephan
macMenuBar-6.patch
Description: Binary data
