On Wed, Dec 11, 2013 at 11:25 AM, Vincent van Ravesteijn <v...@lyx.org> wrote:
> Scott Kostyshak schreef op 6-12-2013 18:23:
>> When looking at other's commits regarding the LyX documents, it is
>> difficult for me to understand what was changed by lyx2lyx and what
>> was added by the commiter. Thus, I'm proposing that one commit does
>> only the lyx2lyx and the following commit makes the substantial
>> changes. See the following two commits:
>>
>> http://www.lyx.org/trac/changeset/84c12ab6/lyxgit
>> http://www.lyx.org/trac/changeset/033b49df/lyxgit
>>
>> I'm not proposing that this be a strict rule for anyone committing
>> changes to the docs. I'm just curious on whether anyone advises in
>> favor of/against or is indifferent.
>>
>> Scott
>
> Yes, it would indeed be good to split the commits. However, I'm not fond
> of the phrase "Prepare for next commit". Just say what you did and it is
> fine: "***.lyx: Update lyx format" would be enough IMO.

Makes sense. I guess it will be clear that I'm doing it for a future
commit so it would be wasted time of people reading the extra line in
the message.

Scott

Reply via email to