10/09/2013 09:01, Vincent van Ravesteijn:
I had a look at the branch, and I have the following comments:
- In the commit logs, it is nowhere mentioned why the cleanups are
necessary.
Indeed... But removing #ifdef's is always good, isn't it?
- In commit ed55131e8, the "automake subdirs" is silently introduced. As
this change has caused such a lot of work, it should really be a
separate commit, and should explain that the other commits were needed
to allow this. In this same commit, the TEX2LYX defines are removed.
This should be a separate commit, or be merged with the work that was
needed in removing the TEX2LYX defines.
Yes, this should be the final commit. How can one split a commit in two?
- The commit about splitting the encoding stuff and moving helper
functions into a new class, should really have some explanation why this
is needed, and why we would need a new class for this.
[...]
I let Stephan answer on those.
- The change to src/tex2lyx/tex2lyx.cpp is unexpected in a commit that
says it removes something from ModuleList.cpp.
Most of my commits are build like that: a dummy implementation is
created to avoid an #ifdef in the code that needs the said function. Do
you want me to modify the commit logs?
JMarc
