On Sun, Aug 25, 2013 at 11:16 PM, Josh Hieronymus <josh.p.hierony...@gmail.com> wrote: > The branch, xhtml/bugs/8280, has been updated. > > - Log ----------------------------------------------------------------- > > commit 8d064e947c4bca803983d11c92ba89733f2ad91a > Author: Josh Hieronymus <josh.p.hierony...@gmail.com> > Date: Sun Aug 25 23:13:10 2013 -0400 > > Include MathFactory.h in InsetMathBig.cpp >
Hi Josh, All of your commit messages seem to have only one line. It would be useful if you provided more details. This is just my opinion so feel free to ignore me unless others also ask for more details as well. I know there are other "commit message style guides" out there (I've noticed a lot of Github users have very short commit logs, perhaps because of the web interface Github uses), but in my opinion more details can't hurt (the follower can always choose just to read the first line). Even for this simple commit, I'm left wondering _why_ you're including the header. Did you forget it in the previous commit? Was a function declaration moved out of a different header into MathFactory.h in a different commit? Note that I'm guilty of writing detail-less commit messages as well [1]. Best, Scott [1] http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg180486.html
