Am 02.08.2013 um 10:19 schrieb Vincent van Ravesteijn <v...@lyx.org>:
> > > > On Mon, Jul 29, 2013 at 10:34 AM, Stephan Witt <st.w...@gmx.net> wrote: > Am 28.07.2013 um 17:09 schrieb Richard Heck <rgh...@lyx.org>: > > > On 07/28/2013 08:46 AM, Stephan Witt wrote: > >> Hi, > >> > >> while studying the script configure.py I saw a problem in "def > >> checkProg()": > >> > >> The array progs parameter gets the lyx_binary_dir as content. > >> The individual elements of the array are split at ' ' to separate > >> command and arguments. This does not work for lyx_binary_dir > >> values containing a space. > >> > >> Sorry, I don't know how to fix that. > > > > I see, in places like checkConverterEntries(). > > > > I am not sure what to do about that either. One would have to change how > > the arguments are passed, obviously. > > Here is a patch to solve this. It should go in, IMHO. > > The patch solves two issues: > > 1) The path extension was done inside a loop. > So the lookup of alternative commands was done > many times too often. > > 2) The lyx_binary_dir needs to be passed as additional > path variable. The command name(s) must not contain an > absolute path because it's split on spaces later. > It doesn't work for commands with spaces in name too - > but this is not that common :) > > Stephan > > PS. Vincent, please check this patch. > It rewrites your latest changes. > > > Hi Stephan, > > This doesn't look to be correct. > > With your patch we look for the 'tex2lyx' binary in the directory > <lyx_binary_dir>/tex2lyx. My latest change made it possible to also look in > <lyx_binary_dir>. Because of the variable naming I didn't got it. > This was needed for CMake builds and is no longer possible now. Ok, so this updated patch is correct then? Stephan
0003-configure-pathnames.diff
Description: Binary data
