On Fri, Aug 2, 2013 at 10:39 AM, Scott Kostyshak <skost...@lyx.org> wrote:
> On Fri, Aug 2, 2013 at 4:25 AM, Vincent van Ravesteijn <v...@lyx.org> > wrote: > > > > > > > > On Fri, Aug 2, 2013 at 2:00 AM, Scott Kostyshak <skost...@lyx.org> > wrote: > >> > >> If a .lyx file has no 'default_output_format' property > >> (that is, not even 'default'), then it is malformed and > >> the test should fail. > >> > >> Before this patch, we guess that the correct format to test with is > 'pdf'. > >> > >> Comments? > >> > > > > > > I do not agree a .lyx file is malformed if it has a default > > 'default_output_format'. > > > > You might say we can use this rule for the .lyx files we ship with LyX, > so > > that the user can compile the files even if he has chosen a 'strange' > > default format. > > > > Either I'm misreading what you wrote or you misread what I wrote. I > agree that a default 'default_output_format' is fine. The patch is > regarding the case when there is no 'default_output_format' at all. > Yes, I misread what you wrote. I somehow assumed that you meant that if there is no default output format set or when the default output format is set to 'default', the tests do not know which format is supposed to succeed. > > By the way, what is the correct word for what I called "property" > above? What is our technical term for the property/command/keyword > "\default_output_format" ? > The technical term would be "buffer param" as they are defined in the class BufferParams. A nicer term is "document setting" as they are changed in the "Document Settings" dialog. About the patch... why do we care about malformed LyX documents ? How can this happen ? Are there some documents in a very old fileformat. Then we should update those. Vincent
