On Sat, Jul 27, 2013 at 09:56:30AM +0200, Jürgen Spitzmüller wrote:

> Am Freitag 26 Juli 2013, 20:53:44 schrieb Enrico Forestieri:
> > commit 92863de517bfa12d36a308bb332700a29565424f
> > Author: Enrico Forestieri <for...@lyx.org>
> > Date:   Fri Jul 26 20:52:44 2013 +0200
> > 
> >     Fix Qt5 decimal separator bug
> >     
> >     Always use '.' as the decimal separator in the GUI, because we
> >     call setlocale(LC_NUMERIC, "C") in setLocale() (GuiApplication.cpp).
> 
> This fix is wrong, it breaks localization support. In the German GUI, the 
> decimal separator must be a comma, and it is now a dot.

You had more than 2 weeks for commenting on the two different patches that
I proposed. You were silent, so I applied the patch for which JMarc expressed
a preference.

BTW, your "fix to the fix" is much more complicated than the other proposed
patch. I suggest that you post your proposed changes and then wait for at
least a couple of days before applying them, otherwise it may seems that you
are forcing your preferences upon all others.

-- 
Enrico

Reply via email to