Op 23-7-2013 20:22, Kornel Benko schreef:
Am Dienstag, 23. Juli 2013 um 19:58:48, schrieb Vincent van Ravesteijn
<v...@lyx.org>
> Op 23-7-2013 19:29, Kornel Benko schreef:
> >
> > Am Dienstag, 23. Juli 2013 um 19:05:55, schrieb Vincent van
Ravesteijn
> > <v...@lyx.org>
> >
> > > commit 33aef1befede724ec478a70f4e13675eff730d06
> >
> > > Author: Vincent van Ravesteijn <v...@lyx.org>
> >
> > > Date: Tue Jul 23 18:36:23 2013 +0200
> >
> > >
> >
> > > CMake: xvkbd: Compile fix if none of the libraries is found
> >
> > >
> >
> > > If no libraries are found, XVFBDLIBS is not initialized and the
> > command "list(REMOVE_DUPLICATES XVFBDLIBS)" fails. So, initialize
> > XVFBDLIBS beforehand.
> >
> > >
> >
> > > diff --git a/development/autotests/CMakeLists.txt
> > b/development/autotests/CMakeLists.txt
> >
> > > index 10abf4c..06fe4af 100644
> >
> > > --- a/development/autotests/CMakeLists.txt
> >
> > > +++ b/development/autotests/CMakeLists.txt
> >
> > > @@ -6,7 +6,7 @@
> >
> > >
> >
> > > if(Q_WS_X11)
> >
> > > set(Missing)
> >
> > > - set(XVFBDLIBS)
> >
> > > + set(XVFBDLIBS "")
> >
> > > # Make sure, the needed programs are in PATH
> >
> > > find_program(PCREGREP_EXE "pcregrep")
> >
> > > if (NOT PCREGREP_EXE)
> >
> > This is not OK. XVFBDLIBS is a list, not a string. Here it would be
> > the first element.
> >
>
> Technically, a list is a string.
Not exactly. set(a "b" "c") is a list, internal value is "b;c".
You can see the output in
message(STATUS "a = ${a}")
as opposed to
message(STATUS "a = " ${a})
> So, where are these lines for:
>
> set(Missing)
> set(XVFBDLIBS)
Initialisation.
Are you sure ?
Why does "list (REMOVE_DUPLICATES XVFBDLIBS)" then say:
"CMake Error: list sub-command REMOVE_DUPLICATES requires list to be
present"
Apparently, there is no initialisation of an empty list.
Vincent
