Hi, On 6 July 2013 15:04, Stephan Witt <st.w...@gmx.net> wrote:
> IMHO, the current state is a result of using system() call at first > because of platform independency and it is never moved to the execv() > style later because using QProcess is an option only. > Now that I'm more familiar with that code, I think I can tackle it and convert all calls to execv style with explicit stdin/stdout/stderr. To support compilation without QProcess, I suggest taking the execv style parameters (together with file names) and constructing a system() call with proper quotation. Such refactoring should result in a cleaner code, and be better security-wise as the task of proper quotation would be handled in a single location. What do you think about the suggest change? BTW why can't we deprecate building without QProcess? Also, being kind of new to lyx-devel, what's the preferred way to submit such changes? As I'll probably have a local branch with a couple commits for it, I can submit a series of patches, or I can put a copy of my git rep online and submit a pull-request. Regards, Guy
