Am 24.06.2013 um 18:59 schrieb Scott Kostyshak <skost...@lyx.org>:

> On Mon, Jun 24, 2013 at 11:13 AM, Stephan Witt <st.w...@gmx.net> wrote:
>> Am 24.06.2013 um 08:34 schrieb Scott Kostyshak <skost...@lyx.org>:
> 
>>> The patch I posted was wrong. When in an inset, if you go up, you go
>>> to the beginning of the buffer. Using LFUN_INSET_BEGIN_SELECT is more
>>> reasonable, but is that what we want? Do we want this behavior only on
>>> the first and last line of the buffer? LFUN_UP inside an inset should
>>> not be changed from the current behavior. It's less clear for
>>> LFUN_UP_SELECT inside an inset.
>> 
>> Ooops… You're right, of course. Thank you.
>> 
>> I've made another attempt to do it right.
>> 
>> This implements the mac-like behavior when being at the first/last line of 
>> the document.
>> I tried to find an application with the concept of an inset and couldn't 
>> find any.
>> So I decided to leave the behavior for inset boundaries untouched.
> 
> Thanks, Stephan. I tested your patch and it works well. But since it
> touches some important parts of the code, should we wait until 2.1.1?


Thanks for testing it.

Yes, I think it has to wait. I didn't want to duplicate code and therefor 
refactored it.
But, I'm not sure what the state of trunk currently is…

Stephan

Reply via email to