Am 03.06.2013 um 09:53 schrieb Stephan Witt <st.w...@gmx.net>: > Am 03.06.2013 um 02:58 schrieb Enrico Forestieri <for...@lyx.org>: > >> On Sun, Jun 02, 2013 at 10:47:01AM +0200, Stephan Witt wrote: >>> Am 02.06.2013 um 10:24 schrieb Georg Baum <georg.b...@post.rwth-aachen.de>: >>>> , or trac: >>>> http://www.lyx.org/trac/browser/lyxgit/src/support/Package.cpp?annotate=blame >>>> >>>> . This tells you that Enrico introduced the quote_python argument in >>>> http://www.lyx.org/trac/changeset/c73eb3497aa3e34b2536cf44071053d30d5c5166/lyxgit >>>> >>>> . Since Enrico is an expert in these things I would use a little bit of >>>> cargo cult and keep the quote_python flag. Or better, ask him about the >>>> reasons and document them. >>> >>> @Enrico: what do you say what should be done here? >> >> Eh... this was more than four years ago, so I had to reconstruct the facts. >> At the time of the commit above, there was no parser for QProcess, so I >> had to use the quote_python flag for obtaining something which could be >> directly passed to Qt. Shortly after, I wrote the parser but forgot that >> flag, apparently. Hopefully, it can be ditched safely now. > > Ok, thank you. I'll make a test case and see what should be done. >
IMO quote_python shouldn't be used here. I placed the application at a location with a backslash in path name. * with quote_python: support/Systemcall.cpp (243): Running: python -tt "/Users/Shared/lyx\\test/LyX-2.1.0dev.app/Contents/Resources/configure.py" --with-version-suffix=-2.1 --binary-dir="/Users/Shared/lyx\\test/LyX-2.1.0dev.app/Contents/MacOS/" python: can't open file '/Users/Shared/lyx\\test/LyX-2.1.0dev.app/Contents/Resources/configure.py': [Errno 2] No such file or directory support/Systemcall.cpp (277): Systemcall: 'python -tt "/Users/Shared/lyx\\test/LyX-2.1.0dev.app/Contents/Resources/configure.py" --with-version-suffix=-2.1 --binary-dir="/Users/Shared/lyx\\test/LyX-2.1.0dev.app/Contents/MacOS/"' finished with exit code 2 * w/o quote_python: LyX: Erstellen des Verzeichnisses /Users/test/Library/Application Support/LyX-2.1/ LyX: Konfiguriere das Benutzerverzeichnis neu support/Systemcall.cpp (243): Running: python -tt "/Users/Shared/lyx\test/LyX-2.1.0dev.app/Contents/Resources/configure.py" --with-version-suffix=-2.1 --binary-dir="/Users/Shared/lyx\test/LyX-2.1.0dev.app/Contents/MacOS/" Having a backslash in path name is causing the problem. I admit that this is a corner case… Stephan
binary_dir3.patch
Description: Binary data
