Op 3-6-2013 17:49, Stephan Witt schreef:
Am 03.06.2013 um 17:33 schrieb Vincent van Ravesteijn <v...@lyx.org>:
Op 3-6-2013 17:05, Jürgen Spitzmüller schreef:
Jean-Marc Lasgouttes wrote:
However, the problem might hit us on more places, and the question is if
we
want convert<string> to be at all locale dependent.
I think that nothing should be locale dependent.
So should we replace the lexical_casts with stream conversions? Would this
affect performance? Or is there anything better? (QString::setNum is not
locale-dependent, as it were).
Jürgen
Isn't it the safest to add "setlocale(LC_NUMERIC, "C") to
GuiApplication::setLocale()" ?
We used to do this before, and this fixes also the other places where we might
get hit.
Vincent
I wouldn't call this a fix.
Isn't it better to change the offending conversions in
lyx/src/support/convert.cpp?
http://www.boost.org/doc/libs/1_47_0/libs/conversion/lexical_cast.htm#lexical_cast
says:
"Where a higher degree of control is required over conversions, std::stringstream
and std::wstringstream offer a more appropriate path."
Stephan
I don't say this is the best 'fix', I only say it might be the safest
for now as it just reverts what we had before. Just because maybe there
are some dark corners in the LyX codebase where suddenly there pops up
another locale dependent issue.
Vincent
