Kornel Benko wrote:

> Am Montag, 13. Mai 2013 um 21:56:33, schrieb Georg Baum <b...@lyx.org>
>>     Kornel, it would be nice if you could do the cmake part.
>> 
> 
> Sure, but at least this one part
> -Wl,--allow-multiple-definition
> does not look portable.

No, it is not portable at all. However, this is only a minor annoyance: The 
microsoft linker is much more liberal concerning multiple definitions, so I 
believe that it should just work without any setting on windows (but the one 
you added should not harm).
The real problem is of course the hack in 
src/support/tests/dummy_functions.cpp which requires multiple definitions. 
This was not my doing. A proper solution would be to make a clean design: If 
nothing in src/support would depend on getGuiMessages() and getMessages() 
from src/LyX.cpp, then no dummy definitions would be needed. I believe 
however that this would need major refactoring.

> P.S.
> Using GLOB expression (as does autotools too)

I know;-) However, in case of tests the worst thing which could happen is 
picking up a broken layout file which would make the test fail. In that 
case, you'll immediately see that it is not an official one.

Thanks for implementing!


Georg


Reply via email to