On Tue, 9 Jan 2001, Angus Leeming wrote:
> Happy New Year to you all and Congratulations to Jürgen and Susanna!
Happy New Year to you also.
> To fix this bug we need to extend the ButtonController a little. However, this
> demonstrates the power of
> Asger's Model/View/Controller separation; the bug is present in many dialogs
> but correct the controller and all the GUI's benefit. Ok, I know.
> ButtonController is Xforms-specific at the moment, but it should be made
> generic.
How generic? All of the code in BC is xforms specific. That's the point
of the Policy and Controller separation. Perhaps you just want an
abstract base class? Or maybe we need a more extensive range of state
machine inputs? Instead of just SMI_VALID and SMI_INVALID we might also
add others related to inputs (but I don't see that being necessary)?
I'll get back to reading this fully later tonight (better go do some work
soon) but maybe you should ask:
Why does input() say the inputs are invalid when Dekel clicks on a key?
AFAI can see input should be returning true not false.
This is more likely to be a problem with the incomplete conversion of some
of the dialogs (particularly the inset-related dialogs like citation) to
using a button controller.
Anyway as I said, I'll reread your proposal later tonight and comment
again then.
Allan. (ARRae)
