Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

[Jean-Marc Lasgouttes]

Le 01/05/2013 20:55, pdv a écrit :
There are 2 occurences of calculate_qt_char_width, in TextMetrics and in
RowPainter.

Yes, I toggled both.

and there is at least one change which is not enclosed by these
conditionals: In TextMetrics I changed rowBreakPoint() to return the
breakpoint as well as the width, so that the subsequent call to
rowWidth() is not needed anymore.

I'm still many  revisions behind master;
I'll catch-up and see what I obtain with pmprof.

It would be surprising that playing catch-up is enough.

I've done some timing with Instruments and a testdocument;
with calculate_qt_char_width=0 GuiPainter::text takes 17.4s
with calculate_qt_char_width=1 GuiPainter::text takes 4.5s

What exactly takes 17.4s?

the time taken by TextMetrics::textMetrics is then 137ms

Was this scrolling problem not an "OS X" issue?

Yes, but I do not have OS X at hand. It is nevertheless important to 
test all platforms.

JMarc