On 08-Jan-2001 Dekel Tsur wrote:
>> Last() returns a pointer so it really should be .. && inset->par->Last() &&
>> shouldn't it?
>
> No, Last() returns LyXParagraph::size_type (= unsigned int).
>
Sure dump from me :(, but what if the inset has more then one paragraph
and one is RTL and the other not???
>> Then IMO this should be fixed in the insettext NOT in the insettabular!
>> I will remove this part of the patch!
>
> Why? this is a fix which is specific for tabular, so it should be in the
> tabular code.
>
Same question as above!
>
> Before the if cluase we have cursor.pos() = inset_pos+1 (because InsertChar
> moved the cursor), and we want to have cursor.pos() = inset_pos, so we need to
> call to CursorLeft() for both RTL and LTR text!
>
Well more or less understood (I would have added this anyway as it is only
RTL related and you're the expert ;)
> No, the language of the pasted text will be the language of the original text
> (i.e. the text which was copied).
> So I don't see a problem here.
>
Hmmm yes your're right!
>> Well the LFUN_UNKNOWN_ACTION is the right thing, but why the tow?
>
> I don't know. I just copied this from lyxfunc.C
>
Well we should at least see what happens I'll let it there for time being.
>> 5. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>> - case LFUN_DOWN:
>> - moveDown(bv);
>
> Because it is not needed (the action will be performed in the switch below).
> Note that we don't have LFUN_UP case, so we don't need LFUN_DOWN.
>
IMO I put this in for a real reason (althought I should have put a comment
there to remeber it now!), so I really think I'll let this in!
> Insert a math inset into a cell of a tabular, and then press space at the
> end of the math inset. The correct behavior is to exit from the math inset
> into the insettext, AND insert space in the insettext after the math inset.
> However, because of the return in the original code, the latter is not done.
> The change I've made fixes this.
>
Hmmm yes, I think you're right we'll see what happens #:O)
>
> Why do you need this? (you can use Home/End).
>
Home/End goes only to the end of a Row if we have a multirow paragraph!
>> would you make selection of columns possible form both directions?
>
> I don't understand what you meant here. Currently, the selection behave the
> same whether the cursor is currently at a left dummy position or at the
> right dummy position.
Assume you have only the position "before the inset" now select the last
column in a tabular!
Jürgen
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
"I am ... a woman ... and ... technically a parasitic uterine growth"
-- Sean Doran the Younger [allegedly]
