08/04/2013 08:26, Juergen Spitzmueller:

     Do not pass thru argument of pass-thru layout literally


-       if (style.pass_thru) {
+       if (style.pass_thru && inset->lyxCode() != ARG_CODE) {
                odocstringstream ods;
                inset->plaintext(ods, runparams);
                os << ods.str();

I do not like much the use of ARG_CODE here. I do not understand why InsetArg::plaintext would output anything, since it is overloaded with a simple int plaintext(odocstringstream &, OutputParams const &, int) const { return 0; }

I suspect that the final int should be a size_t instead.

This gave me the occasion to read InsetArgument.h. I have to say that I am very surprised to find a lot of information that belongs to stylefile, like labelstring_, font_, labelfont_...

This information should be in the textclass. Why isn't this a simple Style entry?

JMarc

Reply via email to