On 04/01/2013 01:51 AM, Scott Kostyshak wrote:
On Mon, Apr 1, 2013 at 1:49 AM, Scott Kostyshak <skost...@lyx.org> wrote:
When using 'find' and a string is not found, this is not an error or a
surprising event. It is often expected (e.g. after searching through
the whole document for a certain string eventually you will get this
message). The exclamation mark should be reserved for messages that
are unexpected or that need extra attention, such as errors.
---
src/BufferView.cpp | 2 +-
src/lyxfind.cpp | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 3aa201b..1d19014 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1545,7 +1545,7 @@ void BufferView::dispatch(FuncRequest const & cmd,
DispatchResult & dr)
if (lyxfind(this, req))
dr.screenUpdate(Update::Force | Update::FitCursor);
else
- message(_("String not found!"));
+ message(_("String not found."));
d->search_request_cache_ = req;
break;
}
diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp
index d6df0ef..e44d640 100644
--- a/src/lyxfind.cpp
+++ b/src/lyxfind.cpp
@@ -379,7 +379,7 @@ bool lyxreplace(BufferView * bv,
Buffer const & buf = bv->buffer();
if (!update) {
// emit message signal.
- buf.message(_("String not found!"));
+ buf.message(_("String not found."));
} else {
if (replace_count == 0) {
buf.message(_("String found."));
@@ -397,7 +397,7 @@ bool lyxreplace(BufferView * bv,
if (findOne(bv, search, casesensitive, matchword, forward))
update = true;
else
- bv->message(_("String not found!"));
+ bv->message(_("String not found."));
}
return update;
}
--
1.7.9.5
This is a personal preference and the original string dates back to
1999 so I would be interested in what others think.
In its current form, it seems to me as if LyX were raising its voice
at the user for doing something wrong.
Seems fine to me. (Native speakers get to decide this kind of thing.)
rh
