The CMake export tests would never fail because the return status was
not checked correctly. The attached patch fixes this.

I guess that CMake is similar to bash in that it does not throw an
error when using an undefined variable? Is there any way to ask it to?

Can the patch go in?

Thanks, Scott
From dbb2fb26e9f5ad79d295249000ed63ada50ac23e Mon Sep 17 00:00:00 2001
From: Scott Kostyshak <skost...@lyx.org>
Date: Sun, 20 Jan 2013 20:36:42 -0500
Subject: [PATCH 1/2] CMake export tests now correctly check return code

---
 development/autotests/export.cmake |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/development/autotests/export.cmake 
b/development/autotests/export.cmake
index bcdcb3a..518886b 100755
--- a/development/autotests/export.cmake
+++ b/development/autotests/export.cmake
@@ -25,7 +25,7 @@ execute_process(
   COMMAND ${lyx} -E ${format} ${file}.${extension} "${LYX_ROOT}/${file}.lyx"
   RESULT_VARIABLE _err)
 string(COMPARE NOTEQUAL  ${_err} 0 _erg)
-if(erg)
+if(_erg)
   message(STATUS "Exporting ${f}.lyx to ${format}")
   message(FATAL_ERROR "Export failed")
 endif()
-- 
1.7.9.5

Reply via email to