Kornel Benko wrote:

> Am Montag, 7. Januar 2013 um 12:03:15, schrieb Jean-Marc Lasgouttes
> <[email protected]>
>> Le 07/01/2013 11:17, Kornel Benko a écrit :
>> > The problem arises, if we export to latex.
>> >
>> > As it is now, the timestamps are written respecting the local timezone.
>> >
>> > Importing this back with tex2lyx, everything is OK, if one happens to
>> > be in same timezone.
>> >
>> > But for different timezones this changes.
>> >
>> > This patch uses GMT for read/write tex.
>> 
>> This looks good.

I like it as well.
 
> I would also change the function-name
> from_ctime() --> from_gmtime()

With your change the old name became indeed wrong. However, from_gmtime() is 
not correct either: gmtime() already returns a time_t, not a string. Maybe 
use from_asctime_utc()?  I also noticed that the documentation in lyxtime.h 
still describes the old behaviour. Please adjust it.


Georg


Reply via email to