Op 27-12-2012 11:05, Juergen Spitzmueller schreef:
The branch, master, has been updated.

- Log -----------------------------------------------------------------

commit 258280cecf0cf2e1f31e7f9136165a7dc494192d
Author: Juergen Spitzmueller <sp...@lyx.org>
Date:   Thu Dec 27 11:05:39 2012 +0100

     Do not force latex_language in arguments (bug #8471)

diff --git a/src/insets/InsetText.cpp b/src/insets/InsetText.cpp
index 55543ab..fac2050 100644
--- a/src/insets/InsetText.cpp
+++ b/src/insets/InsetText.cpp
@@ -266,7 +266,7 @@ void InsetText::doDispatch(Cursor & cur, FuncRequest & cmd)
  {
        LYXERR(Debug::ACTION, "InsetText::doDispatch(): cmd: " << cmd);
- if (isPassThru()) {
+       if (isPassThru() && lyxCode() != ARG_CODE) {
                // Force any new text to latex_language FIXME: This
                // should only be necessary in constructor, but new
                // paragraphs that are created by pressing enter at

I don't know whether it is possible, but is this kind of cases, I would favor a method: "Inset::forceLatexLanguage()".

In other words, I don't like testing on specific type of insets. IMO, the code must be structured such that we could remove the InsetArgument class, and a function in the InsetFactory, and the code should still work.

Vincent

Reply via email to