On 12/21/2012 03:11 AM, Scott Kostyshak wrote:
Attached is an updated patch.
I added the bindings alt-<right> and alt-<left> for move-column
support. These were unbound before.
I thought about suggesting introducing PARAGRAPH_MOVE_{RIGHT,LEFT} but
now I think that would be unnecessary abstraction.
Should I make (four) buttons for the table toolbar? I'm not sure if
this feature is worth adding 4 buttons for. I don't see why a user
would prefer to use a button instead of a keyboard shortcut. I think
the only reason to do this would be to let people know that the
function is there in case they want to find and use the keyboard
shortcut. I have no opinion on this. Either way though, I am curious
as to whether we have svg (or other) originals of the current buttons
or do we only have the png's that are in lib/images/ ?
I think we have pngs. There's a long-standing idea to make svgs.
Some people do prefer toolbars, so if there's room, you might make
icons. (Or see if there are some we can borrow.)
I just found the following lines in stdcontext.inc and stdmenus.inc:
# Item "Swap Rows|S" "inset-modify tabular swap-row" # currently broken
# Item "Swap Columns|w" "inset-modify tabular swap-column" # currently broken
I think that this is what I am trying to implement.
It looks like it goes back to 2002, introduced by this commit: df03e5fc
Should I use the name "move-row" or "swap-row"? I think "move-row" is
more user friendly, but I think "swap-row" is more technically
correct.
It appears that this is currently implemented only for mathed. (See
InsetMathGrid.) I do not know if it works there, or if it is still
broken. If it does the same thing as what you want, then you might try
to make it work similarly.
The only thing that is not working (that I know of) is change
tracking. But this is true for a lot of tabular features so does it
make sense to commit this anyway and then file a bug report for all of
them?
Adding to the problems here doesn't seem so bad.
Richard
