Uwe, sorry to bother you with something minor but I just want to know
if I should forget about this or put it in. It's your call.
Thanks,
Scott
On Thu, Dec 13, 2012 at 7:40 PM, Scott Kostyshak <skost...@lyx.org> wrote:
> On Thu, Dec 13, 2012 at 6:45 PM, Uwe Stöhr <uwesto...@web.de> wrote:
>> Am 08.12.2012 08:09, schrieb Scott Kostyshak:
>>> - I find it unintuitive that a cell that is at the beginning of a
>>> multirow is not "part" of a multirow:
>>> See, for example, Tabular::isPartOfMultiRow.
>>> I guess my confusion is because of:
>>> CELL_BEGIN_OF_MULTICOLUMN,
>>> ///
>>> CELL_PART_OF_MULTICOLUMN,
>>>
>>> From a programming point of view, I understand why they are treated
>>> differently, but from an interface point of view, I wonder if there
>>> could be better names. I can't think of any though.
>>
>>
>> Form the technical point of view there was no other solution and prom the UI
>> point of view as a user you are never confronted with this and thus won't
>> notice.
>
> I agree, but from a "user of the code" perspective I think it is
> confusing. This is not a big issue for me (now that I know the code)
> but I was thinking of how to make things clearer for the next person
> who wants to dig into InsetTabular.{cpp,h}.
>
> This is the only issue remaining and I attached my proposed patch in
> this same email thread (1 day ago I think). I'm attaching the same
> patch to this email for convenience. I don't have a strong opinion so
> if you don't like it I will not insist. What do you think?
>
>>
>>
>>> - My same comment as above but for isPartOfMultiColumn.
>>
>>
>> Dito.
