On 2012-11-03 23:14, Kayvan Sylvan wrote:
> Hi everyone,
>
> I've tested this on Fedora 15, 16, and 17. The Fedora 17 system was a
> clean install on VirtualBox, after which I ran my script.
>
> The basic idea:
>
> lyx-build init # installs needed packages and sets up the rpmbuild dir
> lyx-build rpm # create the RPM files
> lyx-build install # installs the RPMs
>
> subsequent runs:
>
> lyx-build pull # pull the latest sources
> lyx-build rpm # create the RPM files
> lyx-build install # re-install the RPM files
>
> I also added this script to the LyX Wiki.
>
> Best regards,
>
> ---Kayvan
>
>

Hi Kayvan,
    I like the idea of your script and it really helps to test the devel
branch but I would like to suggest some small changes, that in my view
improve the readability of the generated spec file.

I would get rid of most of the old cruft that lies in the spec, most of
the conditionals on old fedora versions are useless by now.

At the same time I would delete the old changelog (a note in your first
entry would be enough).

In terms of the rpm logic I would add a date to the release tag such
that new versions of your rpm can be updated.

Instead of using rpmbuild I would use mock to guarantee that the
resulting lyx does not depend on your system packages.


I hope that this help. Regards,

-- 
José Matos

Reply via email to