Hi, could I have at least some feedback on the patch - I know it is not finished yet (at least for part 5), so it would be good to validate (and maybe commit) parts 1-4.
Many thanks Benjamin On 11 Oct 2012, at 16:51, Benjamin Piwowarski <benjamin.piwowar...@lip6.fr> wrote: > Hi, > > I decomposed the patch in 5 steps: > > 1) Refactored BibTeX parsing (InsetBibtex) > 2) Add a method to update a BibTeX file (InsetBibtex and BiblioInfo) > 3) Detection and status cache of BibTeX managed files (InsetBibtex, Buffer) > 4) Method to add a set of keys to InsetCitation (InsetCitation) > 5) Add bibtex-insert LFUN (LyxAction, BufferView, FuncCode) > > I added to the TRAC ticket a new attachement (bibtex-insert-000.2.patch) that > shows all the steps. Please note that in the TRAC web interface, you can > search for [PATCH to go from one patch to the other. > > Benjamin > > > On Oct 10, 2012, at 16:30 , Richard Heck <rgh...@lyx.org> wrote: > >> On 10/10/2012 09:41 AM, Benjamin Piwowarski wrote: >>> Hi, >>> >>> I created a patch implementing the "bibtex-insert" function, please see >>> >>> http://www.lyx.org/trac/ticket/8368 >>> >>> [snip] >>> >>> The patch basically refactored the code that was used to parse a BibTeX >>> file (in InsetBibtex.cpp), so it can be used to parse the managed file >>> without updating any buffer cache, in order to update the BibTeX file. I >>> also changed the information stored for each bibtex file in order to store >>> the last update timestamp as well as the "managed" flag. >>> >> I'd suggest dividing the patch into pieces. The first one might simply >> refactor the code a bit, then the next one (or two, or however many) add >> additional pieces, one coherent unit at a time. This makes reading the >> patches easier, and also allows any introduced bugs to be localized. >> >> Richard >> > > -- > Benjamin Piwowarski > LIP6/CNRS, University Pierre et Marie Curie (UPMC) > case 169 – 4, Place de Jussieu – 75252 Paris cedex 05 – France > benja...@bpiwowar.net > http://www.bpiwowar.net/ >
