On Sat, Sep 22, 2012 at 5:47 PM, Pavel Sanda <sa...@lyx.org> wrote: > Scott Kostyshak wrote: >> not worth it worrying about the warnings because they are not harmful >> and that by trying to fix them, something could go wrong. The reason I > > That *something could go wrong* is critical. Removing unused variable > or a function is not problem, but changing function calls like str()/data() > just asks for problems.
Good point. OK, I will make a patch to remove the function and nothing else for branch. >> when I compile a program as a user, I trust it more when it does not have >> warnings. > > How many users *compile* anything :) True. And out of those who do, how many look at the warnings? :) You are right -- the potential loss (breaking the code) could be critical and could affect everyone and the potential "gain" (of getting rid of warnings) would be insignificant and would affect only a few. I'll send the one patch for branch and patch for trunk later. Thanks, Scott
