On Sun, Sep 2, 2012 at 4:23 PM, Pavel Sanda <sa...@lyx.org> wrote: > Scott Kostyshak wrote: >> (a) the style is inconsistent > > This is good enough reason. I did grep sources and we indeed use > const_iterator > for end in most cases. > >> (3) I've read that compilers can apply more aggressive optimizations when >> more >> of the data is const. I'm not sure if this would apply here and even if it >> did > > That was my question because I don't think there is any difference here. > The fact that end is not modified anywhere in the loop will be quickly > discovered by compiler optimizations anyway. > > It should make difference when you constify parameter of function or similar. > > Pavel
Is the patch (attached in the first email) OK to go in? Scott
