On 15-Jun-12 11:05 am, Vincent van Ravesteijn wrote:
Op 15-6-2012 11:54, Bogdan Roman schreef:
I still don't see the added value of this script. The script is doing
nothing else than calling cmake with predefined arguments. You said you
want to automate the detection of the arguments, but this is not what
the build script does, this is what is CMake does.
The small conf file is not the ideal solution either. You want CMake to
try to find all relevant paths first, and if it an't find a certain
path, you need to supply it manually. Using a small conf file means that
you have to supply _all_ paths manually, which seems like more annoying
to me.
The conf file would hold only stuff like build-dir, install-dir and
qmake, cmake paths -- the things that needed editing previously and
that can't be quite detected (unless they're in PATH already which by
default they are not). The value would be that a new INSTALL.Win32
file would then only say:
1. edit build.conf and edit the paths in there accordingly
2. run "build debug" or "build release"
The script could then do pretty much everything else, including
downloading and installing the latest Qt-VS2010 and CMake into the
dirs specified in the .conf file (both Qt and CMake installers allow
installation into predefined dirs) and actually finalizing the LyX
installation without any more manual steps.
I'm willing to write one that does all that.
Now you're talking about a different script that automates even more. If
you think such a script makes it much easier...
Please try the CMake GUI and give feedback on what can be improved. Note
that once you have run the CMake GUI to configure, you can compile LyX
from the comand line very easily if you want, because the configuration
parameters are cached.
You seem to have a strong opinion against the script and in favour of
CMake, yet they are conflicting with what LyX is currently
recommending for compilation under Win.
As I wrote, the recommendations should have never been as they are now.
Some consistency and a stable + tried method would benefit LyX. I
was/am only trying to help ...
Until this change to INSTALL.Win32 was made, we were pretty consistent
and we had a stable + tried method.
Actually, the previous INSTALL.Win32 had errors too, and I ran into more
hassle with that method than with the build.bat one (honestly). One
error I remember is that it was asking to point CMake GUI to
lyxsrc\development\cmake\ (which is wrong as CMakeLists.txt is elsewhere).
I appreciate your help, but I would rather see you helping to improve
the CMake scripts and forget about this build.bat script.
Learning CMake syntax is probably below having coffee on my priority
list, although it looks quite innocent. Can the CMakeLists.txt file
trigger the CMake GUI to launch external executables with arguments,
e.g. "Qt-yada-yada-vs2010.exe /D P:\Qt\yada"?
If yes then a lot can be automated and I might actually have a go at it,
and then also amend that pesky INSTALL.Win32 file with fewer (clearer)
steps.
Bogdan.
