Presumably, the "orginal" (prior to 2.02) behavior is a bug. But it's very usable bug. Specifically, all the "how to use LyX in Hebrew" manuals on the Internet (and there are many of these) use it, and will have to change.
So, it will make sense to use the toggle-method, but it will annoy many people. Ronen. On Sun, Apr 29, 2012 at 3:13 PM, Vincent van Ravesteijn <[email protected]> wrote: > Op 29-4-2012 11:29, Stephan Witt schreef: > > This patch restores the font toggle feature if there is no selection. >> I looked into this and it is that way: >> >> Given one invokes the LFUN_LANGUAGE with a value different from current >> one at current position. >> Then the language is changed to the new value. If one passes the current >> one the language it is >> set (back) to the document or default language. >> >> E. g. one has document language english. The first call of "language >> hebrew" switches to hebrew. >> The next call of "language hebrew" switches back to english. >> >> Now I want to ask: is this a bug or a feature? The patch I've posted >> restores the old behavior. >> So it is not bad. But is it good? If nobody objects I'd like to commit >> that thing. >> > > I think it is a bug. I would vote for disabling the LFUN when the > languages are the same. This will make it possible for the reporter to > define: "command-alternatives language hebrew; language english" to toggle. > > I especially object to introduce a difference in behaviour based on the > fact whether there is a selection or not. I would not expect something > different to happen. > > See the attached. > > Vincent >
