On Sun, Feb 19, 2012 at 10:44 PM,  <for...@lyx.org> wrote:
> Author: forenr
> Date: Sun Feb 19 22:44:47 2012
> New Revision: 40783
> URL: http://www.lyx.org/trac/changeset/40783
>
> Log:
> On *nix, a proper forward definition of docstring is necessary for
> overriding a pure virtual method (part of bug #8032).
> I wonder why it was working on Windows and why it works for QString.

docstring is a template and cannot be forward declared (at least not
with current C++ < 11). QString is a plain class.
But I wonder why it was compiling at all.

>
> Modified:
>   lyx-devel/trunk/src/support/ProgressInterface.h
>
> Modified: lyx-devel/trunk/src/support/ProgressInterface.h
> ==============================================================================
> --- lyx-devel/trunk/src/support/ProgressInterface.h     Sun Feb 19 16:52:50 
> 2012        (r40782)
> +++ lyx-devel/trunk/src/support/ProgressInterface.h     Sun Feb 19 22:44:47 
> 2012        (r40783)
> @@ -12,7 +12,8 @@
>  #ifndef LYX_SUPPORT_PROGRESSINTERFACE_H
>  #define LYX_SUPPORT_PROGRESSINTERFACE_H
>
> -class docstring;
> +#include "support/strfwd.h"
> +
>  class QString;
>
>  namespace lyx {

Reply via email to