On Wed, 6 Dec 2000, Jürgen Vigna wrote:
> Hello John!
Hi Juergen !
> This should be fixed but probably I overlooked something I'll have a look
> when I return (if noone else will solve this)!
OK.
> Yes they should be disabled (if I just would know how) as this will be new
> insets in 1.2.0 and then it is automatically fixed ;), but right now this is
> some paragraph hack, I'll will have a look how to disable it!
OK, thanks.
> > void InsetTabular::InsetButtonPress(BufferView * bv, int x, int y, int button)
> > {
> >+ if (button==3)
> >+ return;
> >+
> [snip]
> >fixes it, but I'm not sure it's the right fix. Please advise ...
>
> No as if you just want to change the settings of cell X you should be able to
> just rightclick that cell then the cursor should enter the cell and open (or
> update) the tabular-layout with this cell. But what should be done is to NOT
> activate the inset if button == 3 !
that's the effect this patch has. It ignores a press of button 3, so the
press isn't passed to the text inset's ButtonPress. The ButtonRelease
routine already has similar code for catching this case. After the patch,
the right mouse button will bring up the tabular dialog on button release,
and the inset is not activated.
> I thought I fixed this drawing bug, but as it seems I overlooked somewhere
> something if you can reproduce this and tell me how I can reproduce it I'll
> have a look at this too (as soon as I'm back home ;)
oddly it seems much easier to reproduce at home. I'll try and narrow down
one.
> Thanks for the informations I seem to see that we're more and more stable in
> this code as more or less this are all minor problems IMO ;)
indeed. The new code is a great improvement over what was there before
(from the user's view that is ;)
I have a possibly good idea I would like to pick your brains about for
1.2.0, but I don't want to distract you ;)
thanks
john
--
"Abstinence in moderation."
