Op 8-11-2011 0:46, Tommaso Cucinotta schreef:
Il 07/11/2011 14:46, Tommaso Cucinotta ha scritto:
However, now I broke compilation of lyxclient which complains with errors about not knowing anything about #include <QThread> and you can imagine what else...

this is fixed in the attached refined version of the "SMP debugging" patch. Interestingly, both lyxclient and tex2lyx already used to link with Qt libraries, but the Qt include flags were not there, so I had only to add the latter.

Any opinion against committing this patch that uses a mutex for synchronizing LYXERR() output across multiple threads ?

I don't see an absolute need for it. For now, we don't even use threads now.

If we will ever search in parallel, there shouldn't be any need for so much debug info. A search query will be posted, and a number of threads will execute only a 'simple' task. Besides, of what use is a large amount of debug data generated from several threads which is mixed on your screen in random fashion. There is much debug info now coming out of the find and replace task that I'm wondering whether it is useful anyway.

Vincent

Reply via email to