Il 06/10/2011 23:21, Julien Rioux ha scritto:
On 06/10/2011 11:05 PM, Tommaso Cucinotta wrote:
A few questions:
1) what was exactly the visible problem ? (from your log I can't see
anything
different from what I can see in my own log -- the only problem is
that it
probably still fails to detect the BoundingBox because there's a
residual
direct call to FileName::isZipped() that makes it believe (again -
argh!)
Ah! so you do see the bug then.
I hadn't noticed it before, because I couldn't see any evident
misbehavior. But now that you forced me to look into the log, I can see it.
My easy fix would be to query formats and not even try to call
readBB_from_PSFile() unless the file is actually eps or eps.gz. Can I
ask why is this reading of the bounding box done ? Note that it may also
imply unzipping the file and searching for the contained BB, which may
be expensive. So, imagine I have a .odg (or other non-EPS format).
Should we really convert to EPS, then read the BB ?
Any scenario in which I can see the usefulness of this part of code
where the BB is needed to be extracted from the eps file ? On a related
note, this seems all tightly related to EPS. What if we embed a PNG or
PDF image ?
Thanks,
T.
