Stephan Witt wrote:
> Am 24.02.2011 um 14:10 schrieb Stephan Witt:
>
> > Am 24.02.2011 um 13:36 schrieb Pavel Sanda:
> >
> >> Stephan Witt wrote:
> >>> Index: src/rowpainter.cpp
> >>> ===================================================================
> >>> --- src/rowpainter.cpp (Revision 37780)
> >>> +++ src/rowpainter.cpp (Arbeitskopie)
> >>> @@ -899,7 +899,7 @@
> >>> change_running.color(), Painter::line_solid,
> >>> solid_line_thickness_);
> >>>
> >>> // Change might continue with a different author or type
> >>> - if (change.changed() && !highly_editable_inset) {
> >>> + if (change.changed() /* && !highly_editable_inset */) {
> >>> change_running = change;
> >>> change_last_x = int(x_);
> >>
> >> looks better for normal insets. still something is missing - it looks as
> >> if there more independent painting modes.
> >
> >> one is triggered when i just press normal character - then your fix does
> >> not work and painting line over inset disappear.
> >> other one is when i hoover with mouse with inset. then regardless your fix
> >> works line was there (iirc).
> >> yet another one is when i press enter - then line is again there.
> >
> > Yes, I see. I'll have a look later.
>
> Until now I can see two problems:
> 1. as you noted the insets is painted with different "code paths".
> One cares for CT and the other not, obviously.
> 2. the contents of a deleted inset does not know of its state.
>
> Does anyone know how to derive the pit and pos of the enclosing
> paragraph of an inset (without cursor)?
>
> Currently I'm really short of time and cannot walk many hours
> through the code...
Stephan, what do you think about commit at least the patch above?
i just spent an hour to reinvent your patch, because, well, i forgot you
already proposed it :)
this at least solve the situation when you have strike through inset with some
text, like note.
math and or inset label behave quite crazy, they are painted through different
route and i have no idea how to fix them.
pavel
>
> Stephan
Pavel Sanda wrote:
> hi,
>
> have some text with eg. note inset. switch on revision tracking.
> delete the whole inset.
>
> the strikethrough line which crosses button shows only when you
> hoover with mouse over the collapsed inset. when its uncollapsed
> or edited with keyboard the line disappears.
>
> thus deleting the whole inset is invisible, except one pixel
> on the left side of inset. it seems we almost do the thing
> correctly except that one repaint is missing(line) or redundant
> (inset 'button' grey only).
>
> i couldn't find it in bugzilla although its not just some painting
> glitch. it makes CT with insets quite annoying.
>
> can some painting expert have a look?
> pavel
