On 15.05.2011 18:30, Uwe Stöhr wrote:
Am 15.05.2011 10:03, schrieb Vincent van Ravesteijn:
Wouldn't it be a good idea to:
- first discuss this with Richard and the CMake people,
- wait until the work in trunk has finished,
- wait until it is confirmed that everything works fine for all platforms,
- let the CMake people do the backport themselves if wanted ?
OK, OK.
Nevertheless, I was able to compile LyX 1.6.x using CMake but not LyX 2.0.x. We
should assure that
every branch is at least compilable, despite the work on new features of the
build systems.
With my commit I'm able to compile the LyX 2.0.x branch and to continue with
the installer work.
I will not commit anything further.
I would really wonder if branch wouldn't have compiled with cmake, I've tested
it on several systems.
You have now duplicated all CMake files in branch. There is a file
src/CMakeLists.txt
as well as a file development/cmake/src/CMakeLists.txt. Why did you duplicate
them ?
Are you planning to keep them both in sync for the rest of the 2.0.x cycle ?
I understand you like it that branch compiles the same as trunk, but consider
the
people only using branch. Suddenly the way to compile LyX differs
(significantly)
between versions 2.0.0 and 2.0.1 (which usually is only a quick major bug fix
release).
I see now. Should I revert my commit?
Yes, I would revert it. All the changes are "2.1" changes.
I don't know much about CMake, but as I'm more or less forced to use it, I need
it to compile LyX
2.0.x. The duplicated CMakeLists.txt is surely a mess.
But what do you mean with "differs (significantly) between versions 2.0.0 and
2.0.1"? I could never
compile LyX 2.0.0 from the 2_0_x branch using CMake, but only from trunk. But
trunk is now beyond
the point where the 2_0_x branch was created. OK, I see my loss of technical
knowledge is my mayor
problem.
When there is a problem with cmake in 2.0.1 I'll fix it on base of the 2.0.0
cmake files.
I need to compile LyX 2.0.x to start my work on the installer (required to
handle things like the
hunspell and iconv integration).
OK, this is a problem, having different cmake systems in 2.1 and 2.0 makes it
harder to maintain both systems.
Simplest would be you use for 2.0 the old installer code and you work only on
2.1/trunk.
Peter
Please reconsider your motivations to commit such kind of changes.
I try to do but I often don't realize the problematic. I mean, I see that
something doesn't work and
try to fix it. If it then works and the fix seems to me obvious, I want to put
it in.
sorry and regards
Uwe
