Richard Heck wrote: > On 04/26/2011 06:03 PM, Pavel Sanda wrote: >> Richard Heck wrote: >>> By the way, should we be setting x_target_ here once we have calculated >>> it? >>> I do not understand this code very well. >> i can't comment on the code either, but is there some estimate how >> risky is this patch wrt to new regressions? >> > I think it's completely unrisky. The only case where it makes a real > difference is the case where we risk a crash. The question I asked, if we > should set the x_target_, that's something we're not doing as it is, so not > doing it still can't hurt anything.
then go on. pavel