-------- Original-Nachricht --------
> Datum: Thu, 14 Apr 2011 16:30:10 -0400
> Von: Richard Heck <rgh...@comcast.net>
> An: Peter Kuemmel <syntheti...@gmx.net>
> CC: lyx-devel@lists.lyx.org
> Betreff: Re: #7394, Crash in reverse serach

> On 04/14/2011 03:59 PM, Peter Kuemmel wrote:
> >> This patch
> >>
> >>      http://www.lyx.org/trac/attachment/ticket/7394/resetAnchor.patch
> >>
> >> fixes the crash in
> >>
> >>      http://www.lyx.org/trac/ticket/7394
> >>
> >> But I don't know if it introduces any side effects.
> >>
> > The code before the patch,
> >
> >      anchor_ = doc_iterator_begin(buffer());
> >      anchor_.clear();
> >
> > looks like a NOP.
> >
> > Couldn't the assignment be removed?
> >
> Hmm. It does look that way. But I'm inclined to think that maybe it is 
> anchor_.clear() that ought to be removed. We seem to have no anchor at 
> all after that, whereas the first bit sets it to the beginning of the 
> Buffer.
> 

Yes, you are right, the clear was just wrong there.
Removing it also fixes the bug. And fixes other uncovered ones.

Peter


-- 
GMX DSL Doppel-Flat ab 19,99 Euro/mtl.! Jetzt mit 
gratis Handy-Flat! http://portal.gmx.net/de/go/dsl

Reply via email to