On 24 Nov 2000, Lars Gullik Bjønnes wrote:
> John Levon <[EMAIL PROTECTED]> writes:
>
> | This patch implements FormTabCreate, and improves
> | the para dialog.
> |
> | please apply
>
> Ok... are you telling me that qt/qtarch uses TRUE and FALSE for
> boolean values? why? I just hate to see that...
> (it is ... shrug... so C...)
I hate it as well, but it is auto-generated sources after all. In general
you shouldn't need to look in there ... I could I suppose patch qtarch
again, but I'd like to leave this a while so I can collect a set of fixes
for it...
>
> I see that you change a bit in vspace, is it really needed?
look in paradlg.h, the bit I change to remove the thing that looks like :
LyXGlueLength *le = new
LyXGlueLength(params.added_top_space.length().asString());
I needed this to get the +/- lengths out - it is obviously ugly to
generate, and then parse a string. If length() just returns a
LyXGlueLength in the first place, I don't need such ugliness. Only
GlueLengths are ever stored there, and all callers want/can handle a
GlueLength.
Sorry for not justifying the change in my original mail.
> The added functions in lstring are they really needed?
>
Well if I don't have UnsignedInt versions, then I need a cast, and I know
how much you/we hate casts :)
Signed correctness is a good thing IMHO
> We have had this a _long_ time, and the reports from users have not
> been really severe. So I really think we can live with this for 1.1.6
> too.
I think you missed my point - this is almost definitely an xforms bug that
won't go away no matter how much re-wriiting of the graphics handling is
done. I intend to spend some time with the ghostscript source next week,
and maybe get round to a test case for the xforms mailing list.
And I think the reason you don't get many reports is simply because it has
been around for so long. You hear conversations like this around here :
lyxuser: so how are you finding lyx ?
newuser: it's good but when I insert figures, sometimes it never shows
them
lyxuser: oh, it's always done that, you just have to get used to it
So I think people are just *used* to it. I am determined to hit this bug
as hard as I can :)
> | If the figinset.C patch is not acceptable, I would at least like to know
>
> Possibly... but all rewrites tend to introduce new bugs... so I'd
> prefere to wait until after 1.1.6.
Understood, that makes sense :)
thanks
john
--
"I would like to make use of this space to advocate the worship of the potato.
You all profit from this simplest of creations in all its glorious
manifestations. So show some respect and celebrate the spud. Invent a dance,
bake a pie or throw some in the sea but remember to love potatoes."
- The Beta Band
