On Fri, Mar 25, 2011 at 03:34:42PM +0100, Jürgen Spitzmüller wrote: > forenr wrote: > > Author: forenr > > Date: Fri Mar 25 15:21:28 2011 > > New Revision: 38046 > > URL: http://www.lyx.org/trac/changeset/38046 > > > > Log: > > Move to PrefUi the icon set choice and solve problem with translation > > of icon set names. > > GuiPrefs.cpp: In member function ???virtual void > lyx::frontend::PrefUserInterface::update(const lyx::LyXRC&)???: > GuiPrefs.cpp:2492:16: warning: comparison of unsigned expression < 0 is > always > false
Fixed, thanks. > Is there a specific reason why you do not simply use QComboBox's text/data > infrastructure? I am not familiar with it (I don't even know what you are talking about). If you know a better approach, please apply it. Anyway, I took that route in order to have an actual icon set name written in the preferences file instead of a number. In this way, the order of the items in the combo box does not matter. If your approach breaks this fact, I would not like it. -- Enrico
