Jürgen Spitzmüller wrote:
> > Modified:
> >    lyx-devel/trunk/src/LyXRC.cpp
> >    lyx-devel/trunk/src/frontends/qt4/GuiPrefs.cpp
> >    lyx-devel/trunk/src/frontends/qt4/ui/PrefDisplayUi.ui
> 
> Display is the wrong section. This should go to PrefUI.

Also, this

+               default:
+                       rc.icon_set = fromqstr(iconSetCO-
>currentText().toLower());
+                       break;

will break as soon as these strings are translated, or more likely 
transliterated, in a localization (e.g., Japanese, Chinese, Hebrew, Greek). 
You will need to separate text and user data, as we do in other combos as 
well.

Jürgen

Reply via email to