On 03/21/2011 07:30 AM, Stephan Witt wrote:
Am 20.03.2011 um 17:50 schrieb Abdelrazak Younes:
Hi Pavel,
Here is a patch that should fixes #7375. The patch is big but this is mostly
mechanical changes needed for a proper Dock widget and code shuffling:
* Transform Spellchecker.ui into a simple QWidget
* Pimpl all we can
* Remove Close button (as for all other dock widgets)
* Make the dialog buffer independent (as for all other dock widgets)
Please give this patch a try and tell me if it's OK to commit. There are still
quite some bugs for this dialog that I will try to address afterwards.
I tried your first patch and it is an improvement, thanks.
The dock widget obviously is the problem for the broken push button placement
too!
What's the policy with class/file-name after such a change?
Shouldn't they match each other?
Well, GuiSpellchecker class is still there... What we could do is split
out SpellcheckerWidget into its own files. This way the widget could be
reused in another form. There are a lot of such cleanup to do in the
code actually.
I'll test your second patch too, later today.
Please test the latest (3rd?) patch instead.
Abdel.
