Am 19.03.2011 um 12:41 schrieb Vincent van Ravesteijn: > Op 19-3-2011 12:32, Stephan Witt schreef: >> Am 19.03.2011 um 12:03 schrieb Pavel Sanda: >> >>> hi, >>> >>> i would like to release rc2 next monday (28. march). >>> soft freeze should should come around thursday. >>> few days after release i would like to freeze strings for 2.0. >>> >>> anyone have a spare time to look on the crash #7345 ? >> I did it already. AFAICS, the selection starting in text mode >> causes to open the context-edit menu but the fact the right >> click happened inside the math is not considered anywhere. >> Therefor the translated cursor position has no paragraph and >> the crash happens. I propose (again) to check for text mode >> and add a FIXME to care for the correct context menu later. >> >> Stephan > The context-edit menu is the correct menu.
Yes. Because of the selection... > Did you read my comment in the bugreport ? Yes, that's why I said "add a FIXME". I think it makes no sense to crash in expandSpellingSuggestions if it is possible to care for the correct text mode. It's really hard to decide if the call to expandSpellingSuggestions should happen with selections or if it better should be avoided. If a word is selected the call is correct, if the selection spans non-text insets it is not. Why not let it expandSpellingSuggestions decide? Stephan
