Stephan Witt wrote: > > IOW I'd move the hunspellID code to HunspellChecker. > > Ok. And leave the id() method in Language?
It is not used currentyl, so it should be ditched. > > And still, my proposed > > simplification would apply. > > Then there would only one lookup per language. > German => de_DE > German(old) => de-alt > > This may be ok with the dictionaries we distribute ourself. > There we have control over the names. > > But the user may point hunspell to another location. > The current lookup tries code + variety only if variety is not empty. > After that it makes a lookup with code only. > > In case of empty variety your simplification does the same as mine. > In case of non-empty variety it discards a lookup. > Do want to achieve that because you think it's more correct? Yes. In the only case with variety we have now, german, this would load the ngerman dictionary for german, which is obviously not correct. Jürgen
