On Fri, 17 Nov 2000, John Levon wrote:
> On Fri, 17 Nov 2000, Kayvan A. Sylvan wrote:
>
> > IMPO (In My Practical Opinion) it's easier to add the three harmless
> > lines to the source than to write all these tests and header files with
> > conditional logic, etc.
> >
> > Of course, I would be happy to test proposed patches.
> >
> > ---Kayvan
>
> They are not necessarily harmless. You don't know what "mkstemp" is - what
> if it is (silly examples I know) a statement expression, or a define, or a
> macro ?
>
> Of course in this case it is (probably) OK but it is wrong to rely on
> this, as a rule.
>
> I'll have a go at some quick configury for you to test if you want.
>
> john
Rather it seems best to put it in broken_headers.h - your system is broken
if you have functions not defined in headers, after all.
Does this work (you need to --with-broken-headers) ?
thanks
john
--
"If one tells the truth, one is sure, sooner or later, to be found out."
- Oscar Wilde
Index: ChangeLog
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/ChangeLog,v
retrieving revision 1.690
diff -u -p -r1.690 ChangeLog
--- ChangeLog 2000/11/17 11:17:11 1.690
+++ ChangeLog 2000/11/17 19:51:55
@@ -1,3 +1,8 @@
+2000-11-17 John Levon <[EMAIL PROTECTED]>
+
+ * src/broken_headers.h: define mkstemp as needed for
+ Rob's SunOS 4 system
+
2000-11-15 Rob Lahaye <[EMAIL PROTECTED]>
* lib/ui/default.ui: OptItem used for Fax entry
Index: src/broken_headers.h
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/broken_headers.h,v
retrieving revision 1.4
diff -u -p -r1.4 broken_headers.h
--- src/broken_headers.h 2000/03/09 03:36:45 1.4
+++ src/broken_headers.h 2000/11/17 19:51:55
@@ -24,6 +24,12 @@ void bcopy(unsigned char * b1, unsigned
int readlink(char const * path, char * buf, int bufsiz);
int strcasecmp(char const * s1, char const * s2);
+// yes, #ifdef - Sun platforms can have this function
+// without defining it anywhere
+#ifdef HAVE_MKSTEMP
+int mkstemp(char *templ);
+#endif
+
#ifdef __cplusplus
}
#endif
