Il 05/02/2011 02:43, Pavel Sanda ha scritto:
Tommaso Cucinotta wrote:
I'd need this function for faster retrieval of the search and replace
(internal) buffers from within lyxfind.cpp (currently there are wasteful
copies of these buffers made in the GUI, passed as string args to the LFUN,
etc.). Rather than for optimization purposes, I need this to better
encapsulate all the needed string processing in one place (lyxfind.cpp),
instead of having that spread across the model and the GUI.
unless there is some other reason, this exactly looks like refactoring stuff
for 2.1.
you got it right, it is refactoring stuff, but the change is minimal and
its impact is strictly limited to the FindAdv that I'm still debugging.
With ignore format disabled there were inconsistencies to how I
was latex-exporting in FindAndReplace.cpp and lyxfind.cpp in the
various cases, so now I'm separating in a more meaningful way
the functionality and params passing so to avoid too many headaches.
With the autotests machinery I'm seeing that I just fixed a new (07)
test case, but I broke other 2 that were working, so tomorrow I'm
going to hopefully fix'em all.
[ I'm going to share the patch instead of committing, so u can decide;
in my local version I have also the stopLongOperation(), which IMHO
should also go in ASAP, before users complain about LyX freezing on
Advanced Find into manuals... ]
on the other hand i understand there are only certain time holes people have
time to work on lyx coding -- and you are apparently there :)
I need to distract myself from work, u know :-), especially when the
queue is so long that you cannot see its end at the horizon.
so one solution would be to branch 2.0 trunk soon and let people play on
development again or suggest gitorious. what do you think?
I cannot recommend git for the sole reason that I cannot use it.
It is much more complex than other tools (svn), and most of the
times I don't need those additional cool features with off-line
commits, stash, pull/push, checkout/branch and the like. After years
of (light) kernel hacking I didn't convert myself to that. When others
put something on git (including papers we're coauthoring), it's a
nightmare of commands I don't understand :-). That doesn't mean
I cannot learn git of course. Learning how to hack into LyX was far
more complex, probably :-).
T.
