On Sat, Jan 29, 2011 at 08:06:37PM +0100, Stephan Witt wrote:

> Am 29.01.2011 um 19:12 schrieb Enrico Forestieri:
> 
> > On Sat, Jan 29, 2011 at 05:52:08PM +0100, Tommaso Cucinotta wrote:
> > 
> >> Il 29/01/2011 17:13, Tommaso Cucinotta ha scritto:
> >>> 
> >>>> I can also share my template-based one, that avoids code replication
> >>>> and actually turns this burden over the odocstream class itself.
> >>>> Assuming
> >>>> the latter works fine on all architectures, this one should as well :-).
> >>> 
> >>> Forgot to attach.
> >> 
> >> just don't even try it: my own brand new automated tests just started
> >> to fail because, with that template-ish thing, at the first attempt of
> >> typing a character in text-mode LyX was asserting :-).
> >> 
> >> I'm using the Enrico's patch that works fine (at least on my 64-bit
> >> machine).
> > 
> > Yet, I think your idea is right for avoiding code duplication. Let's see
> > whether requiring explicit instantiations works. If yes, adding a
> > forgotten type would only require adding a single-line instantiation
> > declaration.
> > 
> > So, does the attach patch work for you?
> 
> This patch works here too (32 bit on Mac).

Committed, then.

-- 
Enrico

Reply via email to