Am 22.12.2010 um 01:59 schrieb Pavel Sanda: > Stephan Witt wrote: >> When in pedantic mode the compiler issues a warning for hexToInt() in >> src/support/lstrings.cpp. >> It doesn't like passing an integer to sscanf when format is "%x" - this is >> for conversion of a pointer. > > unless it fixes some particular bug, another 2.1 candidate...
Ok, 2.1 then. >> There are two to fix that: >> 1) the C-way - use of strtol() >> 2) the C++-way - using a std::istringstream >> >> What's the best one? > > i slightly prefer 1 because we dont need to include streams. All callers of hexToInt() use it to convert a hex string to a char_type. Perhaps it should be replaced by a hexToChar returning a char_type. Stephan
