Am 31.10.2010 um 17:10 schrieb Uwe Stöhr: > Am 31.10.2010 16:07, schrieb Jürgen Spitzmüller: > >>> The only issue I see right now is that one cannot set a multirow via the >>> dialog What else do you see that is not yet also in LyX 1.6.x? >> >> Yes, but this issue is quite tricky. I'm not even sure it is solvable without >> a complete rewrite of the tabular UI<-> Inset communication (i.e., introduce >> InsetTabularParams). And it must be fixed for 2.0 of course. > > We need Abdel's help here. He has imlemented the new Apply/OK scheme and I'm > sure he knows a solution. I mean it works for setting multicolumns so it > should work also for multirows using the same tabular UI <-> Inset > communication. Abdel? > >> I had just a first deeper look into the current tabular code during the >> recent >> days (where I fixed some issues), and I observed that the new stuff (e.g. the >> mutlirow code) was not integrated properly in many respects. I really like to >> have this cleaned up and working before adding even more complexity to the >> code. > > I currently see only the problem mentioned above now: > http://wiki.lyx.org/Devel/Multirow > I think my patch doesn't increase the complexity a lot -- the edit field is > only used when a cell is multirow. Have you tested my patch? Maybe I have > overseen something and if you find a bug or regression. Then I will of course > agree with you it is better to postpone. > (Without testing it is like judging a book by its cover ;-) ) > >>> Same critics come usually from the users. As it was my idea to support >>> multirow I'm responsible for that mistake and therefore want to fix this >>> missing part of the implementation. Putting this not in right now would >>> mean that users have to wait another year at least until multirows are >>> really usable without TeX-code. >>> Can it therefore go in? >>> I think I tested the patch carefully and it is moreover rather straight >>> forward. >> >> As said, I would prefer to get the tabular dialog in shape before adding new >> stuff. But this is just my personal opinion of course. > > OK, lets wait for additional opinions.
I can understand both of you. You want to get your patch in and the new features added. And Jürgen wants to consolidate code and behavior. But I've to admit, I agree more with Jürgen. Currently I cannot work on the buffer-info of VCS anymore because the InsetInfo dialog doesn't work anymore because of the ASSERTs. I didn't test the tabular dialogs lately - and I didn't test your patch - but one cannot move on before the current state is not fixed. The support for multi-row cells would be nice. But if it conflicts with the LyX release plans you should wait with the discussion until Pavel is back. Stephan
